feat: transform core modules to standalone module functions#3857
Open
ST-DDT wants to merge 2 commits into
Open
feat: transform core modules to standalone module functions#3857ST-DDT wants to merge 2 commits into
ST-DDT wants to merge 2 commits into
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #3857 +/- ##
==========================================
- Coverage 98.91% 98.89% -0.03%
==========================================
Files 905 942 +37
Lines 3146 3247 +101
Branches 564 588 +24
==========================================
+ Hits 3112 3211 +99
- Misses 30 32 +2
Partials 4 4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #3748
Transforms the core modules to standalone module functions.
These core modules are interdependent and thus cannot be transformed on their own.
Most of the conversion steps are done automatically, but some changes have been done manually.
Please note that I renamed some util files to
_, to distinguish files that export an API SMF from those that don't.This PR can be reviewed more easily using two ways
1. Compare automated steps vs PR
2. Verify no diff in modules to #3748 and look at the manual transform commits
Check the individual module transform commits:
Helpers(#3748)Number(#3748)String(#3748)Generate Module Tree(#3748) (Technically automated, but might be interesting anyway)Final Fixes and Cleanup(#3748)Please do not merge any PRs changing anything in the modules after this PR until all modules are transformed.